gst/gstpad.c: fix uninitialized variable warning

Original commit message from CVS:
* gst/gstpad.c: (gst_pad_collect_valist):
fix uninitialized variable warning
* gst/schedulers/entryscheduler.c: (schedule_forward):
fix shadowed variable

diff --git a/ChangeLog b/ChangeLog
index 142d216..9b5f334 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2004-04-04  Benjamin Otte  <otte@gnome.org>
 
+       * gst/gstpad.c: (gst_pad_collect_valist):
+         fix uninitialized variable warning
+       * gst/schedulers/entryscheduler.c: (schedule_forward):
+         fix shadowed variable
+
+2004-04-04  Benjamin Otte  <otte@gnome.org>
+
        * gst/gstpad.c: (gst_pad_collect_array), (gst_pad_collectv),
        (gst_pad_collect), (gst_pad_collect_valist), (gst_pad_selectv),
        (gst_pad_select):

diff --git a/gst/gstpad.c b/gst/gstpad.c
index 5ef9059..2bb01c8 100644 (file)
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -3219,16 +3219,13 @@ gst_pad_collect_valist (GstPad ** selected, GstPad * pad, va_list var_args)
 
   g_return_val_if_fail (GST_IS_PAD (pad), NULL);
 
+  element = gst_pad_get_parent (pad);
+  maxlength = element->numsinkpads;
+  /* can we make this list a bit smaller than this upper limit? */
+  padlist = g_alloca (sizeof (gpointer) * (maxlength + 1));
   while (pad) {
     g_return_val_if_fail (i < maxlength, NULL);
-    if (element) {
-      g_return_val_if_fail (element == gst_pad_get_parent (pad), NULL);
-    } else {
-      element = gst_pad_get_parent (pad);
-      maxlength = element->numsinkpads;
-      /* can we make this list a bit smaller than this upper limit? */
-      padlist = g_alloca (sizeof (gpointer) * (maxlength + 1));
-    }
+    g_return_val_if_fail (element == gst_pad_get_parent (pad), NULL);
     padlist[i++] = pad;
     pad = va_arg (var_args, GstPad *);
   }

diff --git a/gst/schedulers/entryscheduler.c b/gst/schedulers/entryscheduler.c
index bf3095d..0156af3 100644 (file)
--- a/gst/schedulers/entryscheduler.c
+++ b/gst/schedulers/entryscheduler.c
@@ -626,7 +626,6 @@ schedule_forward (Entry * entry)
     return schedule_forward ((Entry *) ((LinkPrivate *) entry)->sink);
   } else if (ENTRY_IS_COTHREAD (entry)) {
     GList *list;
-    Entry *entry;
     GstElement *element = ((CothreadPrivate *) entry)->element;
 
     if (GST_FLAG_IS_SET (element, GST_ELEMENT_DECOUPLED))