rtc: tps65910: Remove redundant dev_warn() and do not check for 0 return after callin...
authorRuan Jinjie <ruanjinjie@huawei.com>
Thu, 3 Aug 2023 08:07:13 +0000 (16:07 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 16 Aug 2023 23:17:34 +0000 (01:17 +0200)
It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

And there is no need to call the dev_warn() function directly to print
a custom message when handling an error from platform_get_irq()
function as it is going to display an appropriate error message
in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230803080713.4061782-3-ruanjinjie@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-tps65910.c

index 75e4c2d..411ff66 100644 (file)
@@ -406,11 +406,8 @@ static int tps65910_rtc_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, tps_rtc);
 
        irq  = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               dev_warn(&pdev->dev, "Wake up is not possible as irq = %d\n",
-                       irq);
-               return -ENXIO;
-       }
+       if (irq < 0)
+               return irq;
 
        ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
                tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,