[lldb-server unittest] Add missing teardown logic
authorAntonio Afonso <antonio.afonso@gmail.com>
Mon, 3 Jun 2019 15:18:15 +0000 (15:18 +0000)
committerAntonio Afonso <antonio.afonso@gmail.com>
Mon, 3 Jun 2019 15:18:15 +0000 (15:18 +0000)
Summary:
This test base class is missing the teardown making the second set of tests extending it to fail in an assertion in the FileSystem::Initialize() (as it's being initialized twice).
Not sure why this isn't failing the build bots.. (unless they're running without asserts?).

With this fix `ninja LLDBServerTests && ./tools/lldb/unittests/tools/lldb-server/tests/LLDBServerTests` successfully runs and passes all tests.

Reviewers: clayborg, xiaobai, labath

Reviewed By: xiaobai, labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D62788

llvm-svn: 362406

lldb/unittests/tools/lldb-server/tests/TestBase.h

index 76ff96a..053ee8f 100644 (file)
@@ -25,6 +25,11 @@ public:
     lldb_private::HostInfo::Initialize();
   }
 
+  static void TearDownTestCase() {
+    lldb_private::HostInfo::Terminate();
+    lldb_private::FileSystem::Terminate();
+  }
+
   static std::string getInferiorPath(llvm::StringRef Name) {
     llvm::SmallString<64> Path(LLDB_TEST_INFERIOR_PATH);
     llvm::sys::path::append(Path, Name + LLDB_TEST_INFERIOR_SUFFIX);