ceph: normalize 'delta' parameter usage in check_quota_exceeded
authorLuis Henriques <lhenriques@suse.com>
Tue, 7 Apr 2020 10:30:19 +0000 (11:30 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 1 Jun 2020 11:22:53 +0000 (13:22 +0200)
Function check_quota_exceeded() uses delta parameter only for the
QUOTA_CHECK_MAX_BYTES_OP operation.  Using this parameter also for
MAX_FILES will makes the code cleaner and will be required to support
cross-quota-tree renames.

Signed-off-by: Luis Henriques <lhenriques@suse.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/quota.c

index 19507e2..7377838 100644 (file)
@@ -361,8 +361,6 @@ restart:
                spin_unlock(&ci->i_ceph_lock);
                switch (op) {
                case QUOTA_CHECK_MAX_FILES_OP:
-                       exceeded = (max && (rvalue >= max));
-                       break;
                case QUOTA_CHECK_MAX_BYTES_OP:
                        exceeded = (max && (rvalue + delta > max));
                        break;
@@ -417,7 +415,7 @@ bool ceph_quota_is_max_files_exceeded(struct inode *inode)
 
        WARN_ON(!S_ISDIR(inode->i_mode));
 
-       return check_quota_exceeded(inode, QUOTA_CHECK_MAX_FILES_OP, 0);
+       return check_quota_exceeded(inode, QUOTA_CHECK_MAX_FILES_OP, 1);
 }
 
 /*