projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fdcfbd6
)
scsi: qlogicfas408: Call scsi_done() directly
author
Bart Van Assche
<bvanassche@acm.org>
Thu, 7 Oct 2021 20:29:02 +0000
(13:29 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:41 +0000
(21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Link:
https://lore.kernel.org/r/20211007202923.2174984-68-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qlogicfas408.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/qlogicfas408.c
b/drivers/scsi/qlogicfas408.c
index 3bbe0b5545d99f8ee8d5b2b22c7b1869a6de7b94..5471c046a4b7c54453448653c395f6bee959a28b 100644
(file)
--- a/
drivers/scsi/qlogicfas408.c
+++ b/
drivers/scsi/qlogicfas408.c
@@
-442,7
+442,7
@@
static void ql_ihandl(void *dev_id)
* If result is CHECK CONDITION done calls qcommand to request
* sense
*/
-
(icmd->scsi_done)
(icmd);
+
scsi_done
(icmd);
}
irqreturn_t qlogicfas408_ihandl(int irq, void *dev_id)
@@
-473,7
+473,6
@@
static int qlogicfas408_queuecommand_lck(struct scsi_cmnd *cmd,
return 0;
}
- cmd->scsi_done = done;
/* wait for the last command's interrupt to finish */
while (priv->qlcmd != NULL) {
barrier();