scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
authorBodo Stroesser <bstroesser@ts.fujitsu.com>
Fri, 19 Jun 2020 17:38:06 +0000 (19:38 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 20 Jun 2020 03:00:32 +0000 (23:00 -0400)
Since commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
queued commands") tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never
checked.  So we can remove it safely.

[mkp: fixed Mike's email address]

Link: https://lore.kernel.org/r/20200619173806.5016-1-bstroesser@ts.fujitsu.com
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Acked-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c

index 560bfec..b38da27 100644 (file)
@@ -181,7 +181,6 @@ struct tcmu_cmd {
        unsigned long deadline;
 
 #define TCMU_CMD_BIT_EXPIRED 0
-#define TCMU_CMD_BIT_INFLIGHT 1
        unsigned long flags;
 };
 /*
@@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
        tcmu_flush_dcache_range(mb, sizeof(*mb));
 
        list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
-       set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);
 
        /* TODO: only if FLUSH and FUA? */
        uio_event_notify(&udev->uio_info);