staging: r8712u: Fix regression in signal level after commit c6dc001

In commit c6dc001 "staging: r8712u: Merging Realtek's latest (v2.6.6).
Various fixes", the returned qual.qual member of the iw_statistics
struct was changed. For strong signals, this change made no difference;
however for medium and weak signals it results in a low signal that
shows considerable fluctuation, When using wicd for a medium-strength
AP, the value reported in the status line is reduced from 100% to 60% by
this bug.

This problem is reported in https://bugzilla.kernel.org/show_bug.cgi?id=42826.

Reported-and-tested-by: Robert Crawford <wrc1944@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 507584b..ef35bc2 100644 (file)
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -2380,13 +2380,7 @@ static struct iw_statistics *r871x_get_wireless_stats(struct net_device *dev)
                tmp_qual = padapter->recvpriv.signal;
                tmp_noise = padapter->recvpriv.noise;
                piwstats->qual.level = tmp_level;
-               /*piwstats->qual.qual = tmp_qual;
-                * The NetworkManager of Fedora 10, 13 will use the link
-                * quality for its display.
-                * So, use the fw_rssi on link quality variable because
-                * fw_rssi will be updated per 2 seconds.
-                */
-               piwstats->qual.qual = tmp_level;
+               piwstats->qual.qual = tmp_qual;
                piwstats->qual.noise = tmp_noise;
        }
        piwstats->qual.updated = IW_QUAL_ALL_UPDATED;