device-manager : Fix svace issues

[Version] 5.0.21
[Profile] Common
[Issue Type] Static Analysis

Change-Id: Ieb797826f339c46cd1c5f4e1b5c7dd749e7bf7fe

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index ce81aceabd8addc4b4ed05eb7b7cca57f960d50d..0f5f8b74ac88bedf230cbc41dcb2130209be7fba 100644 (file)
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -1,6 +1,6 @@
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          5.0.20
+Version:          5.0.21
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+

diff --git a/src/device-manager.c b/src/device-manager.c
index 1b3724c566c3db91bd5373cb2d5b0a44d3884c4a..6f44f033dcc1c7c6c378180bb153d2af09e42d71 100644 (file)
--- a/src/device-manager.c
+++ b/src/device-manager.c
@@ -2226,10 +2226,6 @@ failed :
         pa_hashmap_free(playback);
     if (capture)
         pa_hashmap_free(capture);
-    if (device_item && made_newly)
-        pa_xfree(device_item);
-    if (profile_item)
-        pa_xfree(profile_item);
     return NULL;
 }
 
@@ -2856,8 +2852,6 @@ static struct device_file_info* parse_device_file_object(json_object *device_fil
     return file_info;
 
 failed :
-    if (roles)
-        pa_xfree(roles);
 
     return NULL;
 }
@@ -3125,6 +3119,7 @@ static int handle_device_connected(pa_device_manager *dm, const char *device_typ
 
     if (!(type_info = _device_manager_get_type_info(dm->type_infos, device_type, device_profile))) {
         pa_log_error("Failed to get type_info for %s.%s", device_type, device_profile);
+        return -1;
     }
 
     if((device_item = _device_manager_get_device(dm->device_list, type_info->type))) {
@@ -3800,8 +3795,8 @@ static void handle_get_bt_a2dp_status(DBusConnection *conn, DBusMessage *msg, vo
 
     pa_assert_se((reply = dbus_message_new_method_return(msg)));
 
-    if (!(device_item = _device_manager_get_device(dm->device_list, DEVICE_TYPE_BT))) {
-        if (!(profile_item = _device_item_get_profile(device_item, DEVICE_PROFILE_BT_A2DP))) {
+    if ((device_item = _device_manager_get_device(dm->device_list, DEVICE_TYPE_BT)) != NULL) {
+        if ((profile_item = _device_item_get_profile(device_item, DEVICE_PROFILE_BT_A2DP)) != NULL) {
             is_bt_on = TRUE;
             bt_name = device_item->name;
         }