media: pci: cobalt: Replace GFP_ATOMIC with GFP_KERNEL in cobalt_probe()

cobalt_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/pci/cobalt/cobalt-driver.c
index c8b1a62..4885e83 100644 (file)
--- a/drivers/media/pci/cobalt/cobalt-driver.c
+++ b/drivers/media/pci/cobalt/cobalt-driver.c
@@ -670,7 +670,7 @@ static int cobalt_probe(struct pci_dev *pci_dev,
        /* FIXME - module parameter arrays constrain max instances */
        i = atomic_inc_return(&cobalt_instance) - 1;
 
-       cobalt = kzalloc(sizeof(struct cobalt), GFP_ATOMIC);
+       cobalt = kzalloc(sizeof(struct cobalt), GFP_KERNEL);
        if (cobalt == NULL)
                return -ENOMEM;
        cobalt->pci_dev = pci_dev;