crypto: omap-aes - Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 5 Jul 2022 20:51:41 +0000 (22:51 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Jul 2022 08:43:21 +0000 (16:43 +0800)
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so dd is never NULL.

This is a preparation for making platform remove callbacks return void.

While touching this driver remove a stray empty line.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-aes.c

index 581211a..67a99c7 100644 (file)
@@ -1261,9 +1261,6 @@ static int omap_aes_remove(struct platform_device *pdev)
        struct aead_alg *aalg;
        int i, j;
 
-       if (!dd)
-               return -ENODEV;
-
        spin_lock_bh(&list_lock);
        list_del(&dd->list);
        spin_unlock_bh(&list_lock);
@@ -1279,7 +1276,6 @@ static int omap_aes_remove(struct platform_device *pdev)
                aalg = &dd->pdata->aead_algs_info->algs_list[i];
                crypto_unregister_aead(aalg);
                dd->pdata->aead_algs_info->registered--;
-
        }
 
        crypto_engine_exit(dd->engine);