dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending

commit e6af9b05bec63cd4d1de2a33968cd0be2a91282a upstream.

Cyclic channels must too call issue_pending in order to start a transfer.
Start the transfer in issue_pending regardless of the type of channel.
This wrongly worked before, because in the past the transfer was started
at tx_submit level when only a desc in the transfer list.

Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211215110115.191749-3-tudor.ambarus@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 9a62029..0c9a97e 100644 (file)
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1778,11 +1778,9 @@ static void at_xdmac_issue_pending(struct dma_chan *chan)
 
        dev_dbg(chan2dev(&atchan->chan), "%s\n", __func__);
 
-       if (!at_xdmac_chan_is_cyclic(atchan)) {
-               spin_lock_irqsave(&atchan->lock, flags);
-               at_xdmac_advance_work(atchan);
-               spin_unlock_irqrestore(&atchan->lock, flags);
-       }
+       spin_lock_irqsave(&atchan->lock, flags);
+       at_xdmac_advance_work(atchan);
+       spin_unlock_irqrestore(&atchan->lock, flags);
 
        return;
 }