Addressed missing function prototype warnings.

In C, a function that accepts no arguments should have a (void)
parameter list in its prototype, not an empty () one.  While they are
equivalent in C++, they are not the same in C.  This patch set address
missing prototype related warnings in C code that uses the functions
in question.

Change-Id: Ic5bb65eefd857da03c39d135fd68e43880e7b975
Bug-Tizen: TC-1208
Signed-off-by: Ossama Othman <ossama.othman@intel.com>

diff --git a/ivi-layermanagement-api/ilmClient/src/ilm_client.c b/ivi-layermanagement-api/ilmClient/src/ilm_client.c
index e698e5a..53241fd 100644 (file)
--- a/ivi-layermanagement-api/ilmClient/src/ilm_client.c
+++ b/ivi-layermanagement-api/ilmClient/src/ilm_client.c
@@ -1,3 +1,4 @@
+
 /**************************************************************************
  *
  * Copyright (C) 2013 DENSO CORPORATION
@@ -42,7 +43,7 @@ ilmClient_init(t_ilm_nativedisplay nativedisplay)
 }
 
 ILM_EXPORT void
-ilmClient_destroy()
+ilmClient_destroy(void)
 {
     gIlmClientPlatformFunc.destroy();
 }

diff --git a/ivi-layermanagement-api/ilmClient/src/ilm_client_wayland_platform.c b/ivi-layermanagement-api/ilmClient/src/ilm_client_wayland_platform.c
index 8a05ae1..1476d3c 100644 (file)
--- a/ivi-layermanagement-api/ilmClient/src/ilm_client_wayland_platform.c
+++ b/ivi-layermanagement-api/ilmClient/src/ilm_client_wayland_platform.c
@@ -46,10 +46,10 @@ static ilmErrorTypes wayland_UpdateInputEventAcceptanceOn(
                          ilmInputDevice devices,
                          t_ilm_bool acceptance);
 static ilmErrorTypes wayland_init(t_ilm_nativedisplay nativedisplay);
-static void wayland_destroy();
+static void wayland_destroy(void);
 static ilmErrorTypes wayland_surfaceInitialize(t_ilm_surface *pSurfaceId);
 
-void init_ilmClientPlatformTable()
+void init_ilmClientPlatformTable(void)
 {
     gIlmClientPlatformFunc.getScreenResolution =
         wayland_getScreenResolution;
@@ -253,14 +253,14 @@ static const struct wl_registry_listener registry_client_listener = {
 static struct ilm_client_context ilm_context = {0};
 
 static void
-wayland_destroy()
+wayland_destroy(void)
 {
     struct ilm_client_context *ctx = &ilm_context;
     ctx->valid = 0;
 }
 
 static void
-destroy_client_resouses()
+destroy_client_resouses(void)
 {
     struct ilm_client_context *ctx = &ilm_context;
     struct screen_context *ctx_scrn = NULL;
@@ -291,7 +291,7 @@ wayland_init(t_ilm_nativedisplay nativedisplay)
 }
 
 static void
-init_client()
+init_client(void)
 {
     struct ilm_client_context *ctx = &ilm_context;
 
@@ -325,7 +325,7 @@ init_client()
 }
 
 static struct ilm_client_context*
-get_client_instance()
+get_client_instance(void)
 {
     struct ilm_client_context *ctx = &ilm_context;
     if (ctx->valid == 0) {

diff --git a/ivi-layermanagement-api/ilmCommon/include/ilm_common.h b/ivi-layermanagement-api/ilmCommon/include/ilm_common.h
index 43ecdbd..bc019ad 100644 (file)
--- a/ivi-layermanagement-api/ilmCommon/include/ilm_common.h
+++ b/ivi-layermanagement-api/ilmCommon/include/ilm_common.h
@@ -32,7 +32,7 @@ extern "C" {
  * \return ILM_SUCCESS if the method call was successful
  * \return ILM_FAILED if a connection can not be established to the services.
  */
-ilmErrorTypes ilm_init();
+ilmErrorTypes ilm_init(void);
 
 /**
  * \brief Initializes the IVI LayerManagement Client.
@@ -48,7 +48,7 @@ ilmErrorTypes ilm_initWithNativedisplay(t_ilm_nativedisplay nativedisplay);
  * \return true if client library is initialized
  * \return false if client library is not initialized
  */
-t_ilm_bool ilm_isInitialized();
+t_ilm_bool ilm_isInitialized(void);
 
 /**
  * \brief Commit all changes and execute all enqueued commands since last commit.
@@ -56,7 +56,7 @@ t_ilm_bool ilm_isInitialized();
  * \return ILM_SUCCESS if the method call was successful
  * \return ILM_FAILED if the client can not call the method on the service.
  */
-ilmErrorTypes ilm_commitChanges();
+ilmErrorTypes ilm_commitChanges(void);
 
 /**
  * \brief Destroys the IVI LayerManagement Client.
@@ -64,7 +64,7 @@ ilmErrorTypes ilm_commitChanges();
  * \return ILM_SUCCESS if the method call was successful
  * \return ILM_FAILED if the client can not be closed or was not initialized.
  */
-ilmErrorTypes ilm_destroy();
+ilmErrorTypes ilm_destroy(void);
 
 
 

diff --git a/ivi-layermanagement-api/ilmCommon/src/ilm_common.c b/ivi-layermanagement-api/ilmCommon/src/ilm_common.c
index 540ebf5..45897b3 100644 (file)
--- a/ivi-layermanagement-api/ilmCommon/src/ilm_common.c
+++ b/ivi-layermanagement-api/ilmCommon/src/ilm_common.c
@@ -34,11 +34,11 @@
 
 ILM_EXPORT ilmErrorTypes ilmClient_init(t_ilm_nativedisplay);
 ILM_EXPORT ilmErrorTypes ilmControl_init(t_ilm_nativedisplay);
-ILM_EXPORT void ilmClient_destroy();
-ILM_EXPORT void ilmControl_destroy();
+ILM_EXPORT void ilmClient_destroy(void);
+ILM_EXPORT void ilmControl_destroy(void);
 
 ILM_EXPORT ilmErrorTypes
-ilm_init()
+ilm_init(void)
 {
     return ilm_initWithNativedisplay(0);
 }
@@ -78,13 +78,13 @@ ilm_initWithNativedisplay(t_ilm_nativedisplay nativedisplay)
 }
 
 ILM_EXPORT t_ilm_bool
-ilm_isInitialized()
+ilm_isInitialized(void)
 {
     return gIlmCommonPlatformFunc.isInitialized();
 }
 
 ILM_EXPORT ilmErrorTypes
-ilm_destroy()
+ilm_destroy(void)
 {
     ilmErrorTypes retVal = gIlmCommonPlatformFunc.destroy();
     ilmClient_destroy();

diff --git a/ivi-layermanagement-api/ilmCommon/src/ilm_common_wayland_platform.c b/ivi-layermanagement-api/ilmCommon/src/ilm_common_wayland_platform.c
index a7f90cc..b8fd975 100644 (file)
--- a/ivi-layermanagement-api/ilmCommon/src/ilm_common_wayland_platform.c
+++ b/ivi-layermanagement-api/ilmCommon/src/ilm_common_wayland_platform.c
@@ -28,11 +28,11 @@
 #include "wayland-client.h"
 
 static ilmErrorTypes wayland_init(t_ilm_nativedisplay nativedisplay);
-static t_ilm_nativedisplay wayland_getNativedisplay();
-static t_ilm_bool wayland_isInitialized();
-static ilmErrorTypes wayland_destroy();
+static t_ilm_nativedisplay wayland_getNativedisplay(void);
+static t_ilm_bool wayland_isInitialized(void);
+static ilmErrorTypes wayland_destroy(void);
 
-void init_ilmCommonPlatformTable()
+void init_ilmCommonPlatformTable(void)
 {
     gIlmCommonPlatformFunc.init = wayland_init;
     gIlmCommonPlatformFunc.getNativedisplay = wayland_getNativedisplay;
@@ -76,7 +76,7 @@ wayland_init(t_ilm_nativedisplay nativedisplay)
 }
 
 static t_ilm_nativedisplay
-wayland_getNativedisplay()
+wayland_getNativedisplay(void)
 {
     struct ilm_common_context *ctx = &ilm_context;
 
@@ -84,7 +84,7 @@ wayland_getNativedisplay()
 }
 
 static t_ilm_bool
-wayland_isInitialized()
+wayland_isInitialized(void)
 {
     struct ilm_common_context *ctx = &ilm_context;
 
@@ -96,7 +96,7 @@ wayland_isInitialized()
 }
 
 static ilmErrorTypes
-wayland_destroy()
+wayland_destroy(void)
 {
     struct ilm_common_context *ctx = &ilm_context;
 

diff --git a/ivi-layermanagement-api/ilmControl/src/ilm_control.c b/ivi-layermanagement-api/ilmControl/src/ilm_control.c
index ebb3186..3182d31 100644 (file)
--- a/ivi-layermanagement-api/ilmControl/src/ilm_control.c
+++ b/ivi-layermanagement-api/ilmControl/src/ilm_control.c
@@ -41,7 +41,7 @@ ilmControl_init(t_ilm_nativedisplay nativedisplay)
 }
 
 ILM_EXPORT void
-ilmControl_destroy()
+ilmControl_destroy(void)
 {
     gIlmControlPlatformFunc.destroy();
 }
@@ -428,7 +428,7 @@ ilm_surfaceSetSourceRectangle(t_ilm_surface surfaceId,
 }
 
 ILM_EXPORT ilmErrorTypes
-ilm_commitChanges()
+ilm_commitChanges(void)
 {
     return gIlmControlPlatformFunc.commitChanges();
 }

diff --git a/ivi-layermanagement-api/ilmControl/src/ilm_control_wayland_platform.c b/ivi-layermanagement-api/ilmControl/src/ilm_control_wayland_platform.c
index 265894e..5515f72 100644 (file)
--- a/ivi-layermanagement-api/ilmControl/src/ilm_control_wayland_platform.c
+++ b/ivi-layermanagement-api/ilmControl/src/ilm_control_wayland_platform.c
@@ -130,7 +130,7 @@ static ilmErrorTypes wayland_surfaceAddNotification(t_ilm_surface surface,
                          surfaceNotificationFunc callback);
 static ilmErrorTypes wayland_surfaceRemoveNotification(t_ilm_surface surface);
 static ilmErrorTypes wayland_init(t_ilm_nativedisplay nativedisplay);
-static void wayland_destroy();
+static void wayland_destroy(void);
 static ilmErrorTypes wayland_getNativeHandle(t_ilm_uint pid,
                          t_ilm_int *n_handle,
                          t_ilm_nativehandle **p_handles);
@@ -147,9 +147,9 @@ static ilmErrorTypes wayland_surfaceGetVisibility(t_ilm_surface surfaceId,
 static ilmErrorTypes wayland_surfaceSetSourceRectangle(t_ilm_surface surfaceId,
                          t_ilm_int x, t_ilm_int y,
                          t_ilm_int width, t_ilm_int height);
-static ilmErrorTypes wayland_commitChanges();
+static ilmErrorTypes wayland_commitChanges(void);
 
-void init_ilmControlPlatformTable()
+void init_ilmControlPlatformTable(void)
 {
     gIlmControlPlatformFunc.getPropertiesOfLayer =
         wayland_getPropertiesOfLayer;
@@ -408,7 +408,7 @@ wayland_controller_get_layer_context(struct wayland_context *ctx,
     return NULL;
 }
 
-static struct ilm_control_context* get_instance();
+static struct ilm_control_context* get_instance(void);
 
 static void
 output_listener_geometry(void *data,
@@ -1968,7 +1968,7 @@ registry_control_listener_for_main = {
 static struct ilm_control_context ilm_context = {0};
 
 static void
-wayland_destroy()
+wayland_destroy(void)
 {
     struct ilm_control_context *ctx = &ilm_context;
     ctx->valid = 0;
@@ -1980,7 +1980,7 @@ wayland_destroy()
 }
 
 static void
-destroy_control_resources()
+destroy_control_resources(void)
 {
     struct ilm_control_context *ctx = &ilm_context;
     struct screen_context *ctx_scrn;
@@ -2090,7 +2090,7 @@ control_thread(void *p_ret)
 }
 
 static void
-init_control()
+init_control(void)
 {
     struct ilm_control_context *ctx = &ilm_context;
     struct wayland_context *main_ctx = &ctx->main_ctx;
@@ -2142,7 +2142,7 @@ init_control()
 }
 
 static struct ilm_control_context*
-get_instance()
+get_instance(void)
 {
     struct ilm_control_context *ctx = &ilm_context;
     if (ctx->valid == 0) {
@@ -3522,7 +3522,7 @@ wayland_surfaceSetSourceRectangle(t_ilm_surface surfaceId,
 }
 
 static ilmErrorTypes
-wayland_commitChanges()
+wayland_commitChanges(void)
 {
     ilmErrorTypes returnValue = ILM_FAILED;
     struct ilm_control_context *ctx = get_instance();