net/mlx5: Bridge, fix ageing of peer FDB entries
authorVlad Buslov <vladbu@nvidia.com>
Thu, 26 Jan 2023 13:47:12 +0000 (14:47 +0100)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 8 Feb 2023 03:01:05 +0000 (19:01 -0800)
SWITCHDEV_FDB_ADD_TO_BRIDGE event handler that updates FDB entry 'lastuse'
field is only executed for eswitch that owns the entry. However, if peer
entry processed packets at least once it will have hardware counter 'used'
value greater than entry 'lastuse' from that point on, which will cause FDB
entry not being aged out.

Process the event on all eswitch instances.

Fixes: ff9b7521468b ("net/mlx5: Bridge, support LAG")
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c
drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c

index 8099a21..ce85b48 100644 (file)
@@ -438,10 +438,6 @@ static int mlx5_esw_bridge_switchdev_event(struct notifier_block *nb,
 
        switch (event) {
        case SWITCHDEV_FDB_ADD_TO_BRIDGE:
-               /* only handle the event on native eswtich of representor */
-               if (!mlx5_esw_bridge_is_local(dev, rep, esw))
-                       break;
-
                fdb_info = container_of(info,
                                        struct switchdev_notifier_fdb_info,
                                        info);
index b176648..3cdcb0e 100644 (file)
@@ -1715,7 +1715,7 @@ void mlx5_esw_bridge_fdb_update_used(struct net_device *dev, u16 vport_num, u16
        struct mlx5_esw_bridge *bridge;
 
        port = mlx5_esw_bridge_port_lookup(vport_num, esw_owner_vhca_id, br_offloads);
-       if (!port || port->flags & MLX5_ESW_BRIDGE_PORT_FLAG_PEER)
+       if (!port)
                return;
 
        bridge = port->bridge;