r8169: remove unneeded check from rtl_link_chg_patch
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 15 Feb 2020 13:48:03 +0000 (14:48 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Feb 2020 03:36:05 +0000 (19:36 -0800)
rtl_link_chg_patch() can be called from rtl_open() to rtl8169_close()
only. And in rtl8169_close() phy_stop() ensures that this function
isn't called afterwards. So we don't need this check.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index a2168a1..b6614f1 100644 (file)
@@ -1325,12 +1325,8 @@ static void rtl8169_irq_mask_and_ack(struct rtl8169_private *tp)
 
 static void rtl_link_chg_patch(struct rtl8169_private *tp)
 {
-       struct net_device *dev = tp->dev;
        struct phy_device *phydev = tp->phydev;
 
-       if (!netif_running(dev))
-               return;
-
        if (tp->mac_version == RTL_GIGA_MAC_VER_34 ||
            tp->mac_version == RTL_GIGA_MAC_VER_38) {
                if (phydev->speed == SPEED_1000) {