HID: playstation: fix DualShock4 bluetooth CRC endian issue.

The driver was by accident reading the CRC directly from a hardware
structure instead of using get_unaligned_le32.

Fixes: 2d77474a2392 ("HID: playstation: add DualShock4 bluetooth support.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index f5e0d06..7b5aef5 100644 (file)
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -2131,9 +2131,10 @@ static int dualshock4_parse_report(struct ps_device *ps_dev, struct hid_report *
        } else if (hdev->bus == BUS_BLUETOOTH && report->id == DS4_INPUT_REPORT_BT &&
                        size == DS4_INPUT_REPORT_BT_SIZE) {
                struct dualshock4_input_report_bt *bt = (struct dualshock4_input_report_bt *)data;
+               uint32_t report_crc = get_unaligned_le32(&bt->crc32);
 
                /* Last 4 bytes of input report contains CRC. */
-               if (!ps_check_crc32(PS_INPUT_CRC32_SEED, data, size - 4, bt->crc32)) {
+               if (!ps_check_crc32(PS_INPUT_CRC32_SEED, data, size - 4, report_crc)) {
                        hid_err(hdev, "DualShock4 input CRC's check failed\n");
                        return -EILSEQ;
                }