projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f6fc759
)
mtd: rawnand: vf610: Stop using nand_release()
author
Miquel Raynal
<miquel.raynal@bootlin.com>
Tue, 19 May 2020 13:00:32 +0000
(15:00 +0200)
committer
Miquel Raynal
<miquel.raynal@bootlin.com>
Sun, 31 May 2020 08:53:36 +0000
(10:53 +0200)
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().
Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Stefan Agner <stefan@agner.ch>
Link:
https://lore.kernel.org/linux-mtd/20200519130035.1883-60-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/vf610_nfc.c
patch
|
blob
|
history
diff --git
a/drivers/mtd/nand/raw/vf610_nfc.c
b/drivers/mtd/nand/raw/vf610_nfc.c
index bd9e16de78a2943c6719055b02b4d3d279d37c49..7248c590118367ad8cdac6f0cf4078770277bce8 100644
(file)
--- a/
drivers/mtd/nand/raw/vf610_nfc.c
+++ b/
drivers/mtd/nand/raw/vf610_nfc.c
@@
-917,8
+917,12
@@
err_disable_clk:
static int vf610_nfc_remove(struct platform_device *pdev)
{
struct vf610_nfc *nfc = platform_get_drvdata(pdev);
+ struct nand_chip *chip = &nfc->chip;
+ int ret;
- nand_release(&nfc->chip);
+ ret = mtd_device_unregister(nand_to_mtd(chip));
+ WARN_ON(ret);
+ nand_cleanup(chip);
clk_disable_unprepare(nfc->clk);
return 0;
}