Input: tps65219-pwrbutton - use regmap_set_bits()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 6 Jun 2023 17:42:36 +0000 (10:42 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 6 Jun 2023 18:11:58 +0000 (11:11 -0700)
regmap_set_bits() is equivalent to regmap_update_bits() if mask == val.
The probe function uses regmap_clear_bits() to enable irqs, so
symmetrically make use of regmap_set_bits() to disable them. There is no
semantic difference.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Link: https://lore.kernel.org/r/20230605161458.117361-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/tps65219-pwrbutton.c

index b2d9e5d..eeb9f23 100644 (file)
@@ -123,9 +123,8 @@ static void tps65219_pb_remove(struct platform_device *pdev)
        int ret;
 
        /* Disable interrupt for the pushbutton */
-       ret = regmap_update_bits(tps->regmap, TPS65219_REG_MASK_CONFIG,
-                                TPS65219_REG_MASK_INT_FOR_PB_MASK,
-                                TPS65219_REG_MASK_INT_FOR_PB_MASK);
+       ret = regmap_set_bits(tps->regmap, TPS65219_REG_MASK_CONFIG,
+                             TPS65219_REG_MASK_INT_FOR_PB_MASK);
        if (ret)
                dev_warn(&pdev->dev, "Failed to disable irq (%pe)\n", ERR_PTR(ret));
 }