IB/core: Nullify ib_uobject during allocation
authorMatan Barak <matanb@mellanox.com>
Tue, 18 Apr 2017 09:03:39 +0000 (12:03 +0300)
committerDoug Ledford <dledford@redhat.com>
Thu, 20 Apr 2017 15:44:07 +0000 (11:44 -0400)
Currently, we initialize all fields of ib_uobject straight after
allocation. Therefore, a kmalloc was sufficient. Since ib_uobject
could be embedded in a type specific structure, we nullify it to
spare programmer errors.

Fixes: 3832125624b7 ('IB/core: Add support for idr types')
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/rdma_core.c

index 699a659..41c31a2 100644 (file)
@@ -84,7 +84,7 @@ static int uverbs_try_lock_object(struct ib_uobject *uobj, bool exclusive)
 static struct ib_uobject *alloc_uobj(struct ib_ucontext *context,
                                     const struct uverbs_obj_type *type)
 {
-       struct ib_uobject *uobj = kmalloc(type->obj_size, GFP_KERNEL);
+       struct ib_uobject *uobj = kzalloc(type->obj_size, GFP_KERNEL);
 
        if (!uobj)
                return ERR_PTR(-ENOMEM);