matroska: fix content encoding scope validity check
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Mon, 21 Apr 2014 12:44:15 +0000 (13:44 +0100)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Mon, 21 Apr 2014 16:21:20 +0000 (17:21 +0100)
It's 3 bits, and http://matroska.org/technical/specs/index.html
says it can't be 0.

Coverity 1139660

gst/matroska/matroska-read-common.c

index fd10924..da70720 100644 (file)
@@ -2664,7 +2664,7 @@ gst_matroska_read_common_read_track_encoding (GstMatroskaReadCommon * common,
         if ((ret = gst_ebml_read_uint (ebml, &id, &num)) != GST_FLOW_OK)
           break;
 
-        if (num > 7 && num == 0) {
+        if (num > 7 || num == 0) {
           GST_ERROR_OBJECT (common, "Invalid ContentEncodingScope %"
               G_GUINT64_FORMAT, num);
           ret = GST_FLOW_ERROR;