Fixing coverity issue 1676193, 1676190 and 1676223. 85/290285/1 accepted/tizen/unified/20230323.172518
authortarunkumarmahay1999 <tarun.mahay@samsung.com>
Wed, 22 Mar 2023 11:33:13 +0000 (17:03 +0530)
committertarun.mahay@samsung.com <a.pandia1@samsung.com>
Wed, 22 Mar 2023 11:33:13 +0000 (17:03 +0530)
Change-Id: Iefd1b67bb1c1acd0164f4711e375d8e8aa15262e

src/mobile/hw_key.c
src/status.c
src/wearable/hourly_alert.c [changed mode: 0644->0755]

index e9c9cd2..665f494 100755 (executable)
@@ -173,9 +173,14 @@ static Eina_Bool _long_press_timer_cb(void* data)
        _D("Inside _long_press_timer_cb");
        dbus_util_send_poweroff_signal();
 
-       feedback_initialize();
-       feedback_play_type(FEEDBACK_TYPE_VIBRATION, FEEDBACK_PATTERN_HOLD);
-       feedback_deinitialize();
+       int r = feedback_initialize();
+       if (r == FEEDBACK_ERROR_NONE) {
+               feedback_play_type(FEEDBACK_TYPE_VIBRATION, FEEDBACK_PATTERN_HOLD);
+               feedback_deinitialize();
+       }
+       else {
+               _E("feedback_initialize error : %d", r);
+       }
 
        return ECORE_CALLBACK_CANCEL;
 }
index 3262050..6123f6d 100755 (executable)
@@ -110,13 +110,18 @@ static void _setappl_select_pkg_cb(keynode_t* node, void *data)
        ret_if(!node);
 
        char *fallback_pkg = vconf_get_str(VCONFKEY_STARTER_FALLBACK_PKG);
-       _set_str_with_default(node, fallback_pkg,
-               &s_status_active.setappl_selected_package_name);
-       if (!s_status_active.setappl_selected_package_name)
-               _E("Package name is NULL");
+       if (fallback_pkg != NULL) {
+               _set_str_with_default(node, fallback_pkg,
+                       &s_status_active.setappl_selected_package_name);
+               if (!s_status_active.setappl_selected_package_name)
+                       _E("Package name is NULL");
 
-       _call_callback(STATUS_ACTIVE_KEY_SETAPPL_SELECTED_PACKAGE_NAME);
-       free(fallback_pkg);
+               _call_callback(STATUS_ACTIVE_KEY_SETAPPL_SELECTED_PACKAGE_NAME);
+               free(fallback_pkg);
+       }
+       else {
+               _E("fallback_pkg is NULL");
+       }
 }
 
 static void _setappl_screen_lock_type_cb(keynode_t* node, void *data)
old mode 100644 (file)
new mode 100755 (executable)
index e88c4c2..72af04a
@@ -143,9 +143,14 @@ static int _alarm_cb(alarm_id_t alarm_id, void *data)
 {
        _D("hourly_alert alarm callback called");
 
-       feedback_initialize();
-       feedback_play(FEEDBACK_PATTERN_NONE);
-       feedback_deinitialize();
+       int r = feedback_initialize();
+       if (r == FEEDBACK_ERROR_NONE) {
+               feedback_play(FEEDBACK_PATTERN_NONE);
+               feedback_deinitialize();
+       }
+       else {
+               _E("feedback_initialize error : %d", r);
+       }
 
        return 0;
 }