Make sure verify=False is respected for session even when there has already been...

Update tests to expose the (fixed) problem.

diff --git a/requests/models.py b/requests/models.py
index c45b18a7b306f6d716ae20f29b38606750fd7b9d..957f6789ff831106950f3f2e4c55fc7afa4963d0 100644 (file)
--- a/requests/models.py
+++ b/requests/models.py
@@ -453,6 +453,9 @@ class Request(object):
 
             conn.cert_reqs = 'CERT_REQUIRED'
             conn.ca_certs = cert_loc
+        else:
+            conn.cert_reqs = 'CERT_NONE'
+            conn.ca_certs = None
 
         if not self.sent or anyway:
 

diff --git a/test_requests_ext.py b/test_requests_ext.py
index c86a383cfedea0a48d84a184662ca687607e6d24..9e52a0d5c251ba2c15ac357d3ddd9fa147d78c85 100644 (file)
--- a/test_requests_ext.py
+++ b/test_requests_ext.py
@@ -34,10 +34,10 @@ class RequestsTestSuite(unittest.TestCase):
 
         s = requests.session()
 
-        s.get('https://kennethreitz.com', verify=False)
-
         self.assertRaises(requests.exceptions.SSLError, s.get, 'https://kennethreitz.com')
 
+        s.get('https://kennethreitz.com', verify=False)
+
 
 
 if __name__ == '__main__':