net: mvneta: remove interface checks in mvneta_validate()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 27 Oct 2021 09:03:48 +0000 (10:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 Oct 2021 13:50:11 +0000 (14:50 +0100)
As phylink checks the interface mode against the supported_interfaces
bitmap, we no longer need to validate the interface mode in the
validation function. Remove this to simplify it.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvneta.c

index 7df9236..446cdd4 100644 (file)
@@ -3832,15 +3832,8 @@ static void mvneta_validate(struct phylink_config *config,
         * "Bit 2 Field InBandAnEn In-band Auto-Negotiation enable. ...
         * When <PortType> = 1 (1000BASE-X) this field must be set to 1."
         */
-       if (phy_interface_mode_is_8023z(state->interface)) {
-               if (!phylink_test(state->advertising, Autoneg)) {
-                       linkmode_zero(supported);
-                       return;
-               }
-       } else if (state->interface != PHY_INTERFACE_MODE_NA &&
-                  state->interface != PHY_INTERFACE_MODE_QSGMII &&
-                  state->interface != PHY_INTERFACE_MODE_SGMII &&
-                  !phy_interface_mode_is_rgmii(state->interface)) {
+       if (phy_interface_mode_is_8023z(state->interface) &&
+           !phylink_test(state->advertising, Autoneg)) {
                linkmode_zero(supported);
                return;
        }