[GTK]Popup drop-down menu contains extra empty spaces at beginning and

occupies whole screen when items in popup reaches the height of display device.
https://bugs.webkit.org/show_bug.cgi?id=68533

When implementing the GTK+ menu position function, set pushIn to false, which tell
GTK+ not create a menu that is as big as the entire screen.

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-22
Reviewed by Martin Robinson.

* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 0927f83..7b364a8 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2011-09-22  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
+
+        [GTK]Popup drop-down menu contains extra empty spaces at beginning and 
+        occupies whole screen when items in popup reaches the height of display device.
+        https://bugs.webkit.org/show_bug.cgi?id=68533
+
+        When implementing the GTK+ menu position function, set pushIn to false, which tell
+        GTK+ not create a menu that is as big as the entire screen.
+
+        Reviewed by Martin Robinson.
+
+        * platform/gtk/GtkPopupMenu.cpp:
+        (WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.
+
 2011-09-22  Alpha Lam  <hclam@chromium.org>
 
         Define export symbol correctly due to rename of pageScaleFactor to

diff --git a/Source/WebCore/platform/gtk/GtkPopupMenu.cpp b/Source/WebCore/platform/gtk/GtkPopupMenu.cpp
index c0ac921..d3c54d8 100644 (file)
--- a/Source/WebCore/platform/gtk/GtkPopupMenu.cpp
+++ b/Source/WebCore/platform/gtk/GtkPopupMenu.cpp
@@ -6,6 +6,7 @@
  * Copyright (C) 2008 Collabora Ltd.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 2010-2011 Igalia S.L.
+ * Portions Copyright (c) 2010 Motorola Mobility, Inc.  All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -144,7 +145,7 @@ void GtkPopupMenu::menuPositionFunction(GtkMenu*, gint* x, gint* y, gboolean* pu
 {
     *x = popupMenu->m_menuPosition.x();
     *y = popupMenu->m_menuPosition.y();
-    *pushIn = true;
+    *pushIn = false;
 }
 
 void GtkPopupMenu::resetTypeAheadFindState()