NFS: The 'fattr_valid' field in struct nfs_server should be unsigned int
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 21 Apr 2021 11:48:43 +0000 (07:48 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 21 Apr 2021 11:53:03 +0000 (07:53 -0400)
Fix up a static compiler warning:
"fs/nfs/nfs4proc.c:3882 _nfs4_server_capabilities() warn: was expecting
a 64 bit value instead of '(1 << 11)'"

The fix is to convert the fattr_valid field to match the type of the
'valid' field in struct nfs_fattr.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
include/linux/nfs_fs_sb.h

index d28d7a6..70057b2 100644 (file)
@@ -156,6 +156,7 @@ struct nfs_server {
 #define NFS_MOUNT_WRITE_EAGER          0x01000000
 #define NFS_MOUNT_WRITE_WAIT           0x02000000
 
+       unsigned int            fattr_valid;    /* Valid attributes */
        unsigned int            caps;           /* server capabilities */
        unsigned int            rsize;          /* read size */
        unsigned int            rpages;         /* read size (in pages) */
@@ -191,8 +192,6 @@ struct nfs_server {
        dev_t                   s_dev;          /* superblock dev numbers */
        struct nfs_auth_info    auth_info;      /* parsed auth flavors */
 
-       __u64                   fattr_valid;    /* Valid attributes */
-
 #ifdef CONFIG_NFS_FSCACHE
        struct nfs_fscache_key  *fscache_key;   /* unique key for superblock */
        struct fscache_cookie   *fscache;       /* superblock cookie */