gfx: drv: Correctly set info->par
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 20 Mar 2012 14:46:20 +0000 (16:46 +0200)
committerMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Tue, 3 Jul 2012 09:30:43 +0000 (12:30 +0300)
When using drm_fb_helper, fbdev par is supposed to point to the
drm_fb_helper instance.

This "bug" didn't cause problems as the helper is emedded as the
first member inside the psb_fbdev strcture. But let's make the code
correct nonetheless.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
drivers/staging/mrst/drv/psb_fb.c

index 789f25b..a7f79df 100644 (file)
@@ -68,8 +68,8 @@ static int psbfb_setcolreg(unsigned regno, unsigned red, unsigned green,
                           unsigned blue, unsigned transp,
                           struct fb_info *info)
 {
-       struct psb_fbdev * fbdev = info->par;
-       struct drm_framebuffer *fb = fbdev->psb_fb_helper.fb;
+       struct drm_fb_helper *fb_helper = info->par;
+       struct drm_framebuffer *fb = fb_helper->fb;
        uint32_t v;
 
        if (!fb)
@@ -422,7 +422,7 @@ static int psbfb_create(struct psb_fbdev * fbdev, struct drm_fb_helper_surface_s
                goto out_err1;
        }
 
-       info->par = fbdev;
+       info->par = &fbdev->psb_fb_helper;
 
        psbfb->fbdev = info;