ovl: remove unneeded arg from ovl_verify_origin()
authorAmir Goldstein <amir73il@gmail.com>
Sun, 24 Sep 2017 10:00:19 +0000 (13:00 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Fri, 10 Nov 2017 08:39:16 +0000 (09:39 +0100)
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/namei.c
fs/overlayfs/overlayfs.h
fs/overlayfs/super.c

index 7d40991..625ed80 100644 (file)
@@ -348,8 +348,8 @@ static int ovl_verify_origin_fh(struct dentry *dentry, const struct ovl_fh *fh)
  *
  * Return 0 on match, -ESTALE on mismatch, < 0 on error.
  */
-int ovl_verify_origin(struct dentry *dentry, struct vfsmount *mnt,
-                     struct dentry *origin, bool is_upper, bool set)
+int ovl_verify_origin(struct dentry *dentry, struct dentry *origin,
+                     bool is_upper, bool set)
 {
        struct inode *inode;
        struct ovl_fh *fh;
index cefe5a9..13eab09 100644 (file)
@@ -249,8 +249,8 @@ static inline bool ovl_is_impuredir(struct dentry *dentry)
 
 
 /* namei.c */
-int ovl_verify_origin(struct dentry *dentry, struct vfsmount *mnt,
-                     struct dentry *origin, bool is_upper, bool set);
+int ovl_verify_origin(struct dentry *dentry, struct dentry *origin,
+                     bool is_upper, bool set);
 int ovl_verify_index(struct dentry *index, struct ovl_path *lower,
                     unsigned int numlower);
 int ovl_get_index_name(struct dentry *origin, struct qstr *name);
index 3156e90..be03578 100644 (file)
@@ -983,9 +983,7 @@ static int ovl_get_indexdir(struct ovl_fs *ofs, struct ovl_entry *oe,
        int err;
 
        /* Verify lower root is upper root origin */
-       err = ovl_verify_origin(upperpath->dentry,
-                               oe->lowerstack[0].layer->mnt,
-                               oe->lowerstack[0].dentry,
+       err = ovl_verify_origin(upperpath->dentry, oe->lowerstack[0].dentry,
                                false, true);
        if (err) {
                pr_err("overlayfs: failed to verify upper root origin\n");
@@ -995,8 +993,8 @@ static int ovl_get_indexdir(struct ovl_fs *ofs, struct ovl_entry *oe,
        ofs->indexdir = ovl_workdir_create(ofs, OVL_INDEXDIR_NAME, true);
        if (ofs->indexdir) {
                /* Verify upper root is index dir origin */
-               err = ovl_verify_origin(ofs->indexdir, ofs->upper_mnt,
-                                       upperpath->dentry, true, true);
+               err = ovl_verify_origin(ofs->indexdir, upperpath->dentry,
+                                       true, true);
                if (err)
                        pr_err("overlayfs: failed to verify index dir origin\n");