net: hns3: remove redundant query in hclge_config_tm_hw_err_int()
authorJiaran Zhang <zhangjiaran@huawei.com>
Fri, 26 Mar 2021 01:36:22 +0000 (09:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Mar 2021 21:58:44 +0000 (14:58 -0700)
According to the HW manual, the query operation is unnecessary
when the TM QCN error event is enabled, so remove it.

Signed-off-by: Jiaran Zhang <zhangjiaran@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

index 7389fe905f5389092ef6a299fa5aea6bc38e647b..d25291916b31ba6102f0736523173046a492f603 100644 (file)
@@ -865,13 +865,7 @@ static int hclge_config_tm_hw_err_int(struct hclge_dev *hdev, bool en)
        }
 
        /* configure TM QCN hw errors */
-       ret = hclge_cmd_query_error(hdev, &desc, HCLGE_TM_QCN_MEM_INT_CFG, 0);
-       if (ret) {
-               dev_err(dev, "fail(%d) to read TM QCN CFG status\n", ret);
-               return ret;
-       }
-
-       hclge_cmd_reuse_desc(&desc, false);
+       hclge_cmd_setup_basic_desc(&desc, HCLGE_TM_QCN_MEM_INT_CFG, false);
        if (en)
                desc.data[1] = cpu_to_le32(HCLGE_TM_QCN_MEM_ERR_INT_EN);