[XLA] Two minor style-guide fixups.
authorJustin Lebar <jlebar@google.com>
Tue, 22 May 2018 00:34:56 +0000 (17:34 -0700)
committerTensorFlower Gardener <gardener@tensorflow.org>
Tue, 22 May 2018 00:37:13 +0000 (17:37 -0700)
- Fix TODO(b/123) style.
- Use a value type rather than an rvalue reference for a "sink" param.

PiperOrigin-RevId: 197489597

tensorflow/compiler/xla/service/gpu/sequential_thunk.cc
tensorflow/compiler/xla/service/gpu/sequential_thunk.h

index b50f5b5..88cb108 100644 (file)
@@ -20,7 +20,7 @@ limitations under the License.
 namespace xla {
 namespace gpu {
 
-SequentialThunk::SequentialThunk(std::vector<std::unique_ptr<Thunk>>&& thunks,
+SequentialThunk::SequentialThunk(std::vector<std::unique_ptr<Thunk>> thunks,
                                  const HloInstruction* hlo)
     : Thunk(Kind::kSequential, hlo), thunks_(std::move(thunks)) {}
 
index 3537110..135f79e 100644 (file)
@@ -31,7 +31,7 @@ namespace gpu {
 // require multiple kernel launches or library calls.
 class SequentialThunk : public Thunk {
  public:
-  SequentialThunk(std::vector<std::unique_ptr<Thunk>>&& thunks,
+  SequentialThunk(std::vector<std::unique_ptr<Thunk>> thunks,
                   const HloInstruction* hlo);
   SequentialThunk(const SequentialThunk&) = delete;
   SequentialThunk& operator=(const SequentialThunk&) = delete;