ext/dv/gstdvdec.c: really fix bpp24/32 dvdec caps (classic rgba indeed)

Original commit message from CVS:
* ext/dv/gstdvdec.c:
really fix bpp24/32 dvdec caps (classic rgba indeed)
* gst/asfdemux/gstasfdemux.c:
(gst_asf_demux_process_ext_content_desc):
don't send text tags if they are empty (bis repetita)

diff --git a/ChangeLog b/ChangeLog
index 135614e..6277b25 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,14 @@
 2005-01-08  Stephane LOEUILLET  <stephane.loeuillet@tiscali.fr>
 
        * ext/dv/gstdvdec.c:
+         really fix bpp24/32 dvdec caps (classic rgba indeed)
+       * gst/asfdemux/gstasfdemux.c:
+       (gst_asf_demux_process_ext_content_desc):
+         don't send text tags if they are empty (bis repetita)
+
+2005-01-08  Stephane LOEUILLET  <stephane.loeuillet@tiscali.fr>
+
+       * ext/dv/gstdvdec.c:
         remove unneeded comment from dvdec
          (related to DV 4CC codes in AVI files)
          moved them in gstreamer/docs/random/mimetypes

diff --git a/gst/asfdemux/gstasfdemux.c b/gst/asfdemux/gstasfdemux.c
index 8f66765..eca5ef1 100644 (file)
--- a/gst/asfdemux/gstasfdemux.c
+++ b/gst/asfdemux/gstasfdemux.c
@@ -725,7 +725,6 @@ IsVBR
 
             /* get rid of tags with empty value */
             if (strlen (value)) {
-              have_tags = TRUE;
               g_value_init (&tag_value, G_TYPE_STRING);
               g_value_set_string (&tag_value, value);
             }
@@ -733,16 +732,19 @@ IsVBR
 
           /* 0003 = DWORD */
           if (datatype == 3) {
-            have_tags = TRUE;
             g_value_init (&tag_value, G_TYPE_INT);
             g_value_set_int (&tag_value, GUINT32_FROM_LE ((guint32) * value));
           }
 
-          gst_tag_list_add_values (taglist, GST_TAG_MERGE_APPEND, tags[tag],
-              &tag_value, NULL);
+          if (G_IS_VALUE (&tag_value)) {
+            gst_tag_list_add_values (taglist, GST_TAG_MERGE_APPEND, tags[tag],
+                &tag_value, NULL);
+
+            g_value_unset (&tag_value);
 
-          g_value_unset (&tag_value);
-        };
+            have_tags = TRUE;
+          }
+        }
         j++;
       }
     }