symtab.c (basic_lookup_symbol_nonlocal): Add comment.

gdb/ChangeLog:

	* symtab.c (basic_lookup_symbol_nonlocal): Add comment.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5500c15..882262d 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2014-11-06  Doug Evans  <xdje42@gmail.com>
 
+       * symtab.c (basic_lookup_symbol_nonlocal): Add comment.
+
+2014-11-06  Doug Evans  <xdje42@gmail.com>
+
        * symtab.c (lookup_local_symbol): Renamed from lookup_symbol_aux_local.
        All callers updated.
        (lookup_symbol_in_all_objfiles): Renamed from

diff --git a/gdb/symtab.c b/gdb/symtab.c
index 6f483bf..e2a1e56 100644 (file)
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -1792,6 +1792,10 @@ basic_lookup_symbol_nonlocal (const char *name,
      than that one, so I don't think we should worry about that for
      now.  */
 
+  /* NOTE: dje/2014-10-26: The lookup in all objfiles search could skip
+     the current objfile.  Searching the current objfile first is useful
+     for both matching user expectations as well as performance.  */
+
   sym = lookup_symbol_in_static_block (name, block, domain);
   if (sym != NULL)
     return sym;