build: always add support for assembly targets on Darwin
authorSaleem Abdulrasool <compnerd@compnerd.org>
Wed, 22 Jul 2020 15:54:36 +0000 (08:54 -0700)
committerSaleem Abdulrasool <compnerd@compnerd.org>
Wed, 29 Jul 2020 21:01:02 +0000 (14:01 -0700)
When attempting to build compiler-rt on a developer transition kit, the
build would fail due to `.S` files not being handled properly by the
Ninja generator.  Rather than conditionalising on Xcode, conditionalise
to Darwin.  Because we know that the system compiler is clang based, it
will always properly handle the pre-processing based on the extension.

Differential Revision: https://reviews.llvm.org/D84333

compiler-rt/cmake/Modules/AddCompilerRT.cmake

index efb6608..9c135ef 100644 (file)
@@ -110,7 +110,7 @@ endfunction()
 function(add_asm_sources output)
   set(${output} ${ARGN} PARENT_SCOPE)
   # Xcode will try to compile asm files as C ('clang -x c'), and that will fail.
-  if (${CMAKE_GENERATOR} STREQUAL "Xcode")
+  if(CMAKE_SYSTEM_NAME STREQUAL Darwin)
     enable_language(ASM)
   else()
     # Pass ASM file directly to the C++ compiler.