Fix uninitialized variables of constructor

Change-Id: Iaada67b33961eba98e3abefd52e86bfb8bae2624
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

diff --git a/cion/common/peer_info.cc b/cion/common/peer_info.cc
index 9134a27d293566de17116f43dc734b0c4b1b3cb1..8d2151891a969a3dc14dccd69a0ccce55130dee4 100644 (file)
--- a/cion/common/peer_info.cc
+++ b/cion/common/peer_info.cc
@@ -111,6 +111,7 @@ PeerInfo::PeerInfo(const PeerInfo& peerinfo) {
   app_id_ = peerinfo.GetAppID();
   app_version_ = peerinfo.GetAppVersion();
   uuid_ = peerinfo.GetUUID();
+  channel_id_ = peerinfo.GetChannelID();
 
   valid_ = true;
 }

diff --git a/cion/vine/vine_discoverer.cc b/cion/vine/vine_discoverer.cc
index 56a6173f4c7bd9b51717c6e3de87d0fa3f62f5a4..a61163c57d32e9c490732312cdd725a4c5ead041 100644 (file)
--- a/cion/vine/vine_discoverer.cc
+++ b/cion/vine/vine_discoverer.cc
@@ -40,7 +40,7 @@ constexpr char kVineSvcAttrKey2[] = "svcpart2";
 namespace cion {
 
 VineDiscoverer::VineDiscoverer(std::shared_ptr<VineSession> session)
-    : session_(session) {
+    : session_(session), browser_(nullptr) {
   int ret = vine_session_set_discovered_cb(session_->GetRawSession(),
       [](vine_session_h session, vine_service_h service,
           vine_service_state_e state, void* user_data) {

diff --git a/cion/vine/vine_dp.cc b/cion/vine/vine_dp.cc
index 6f0554a0945a69a6f7b16b88f5e1d091b2b2b5ad..1904826bc7b2c3d399f6254fc60805a187f734c9 100644 (file)
--- a/cion/vine/vine_dp.cc
+++ b/cion/vine/vine_dp.cc
@@ -38,7 +38,9 @@ VineDp::VineDp(vine_dp_h dp, bool is_owned)
 }
 
 VineDp::VineDp(std::shared_ptr<VineSession> session)
-    : session_(session), is_owned_(true) {
+    : dp_(nullptr), session_(session), terminated_handler_(nullptr),
+      opened_handler_(nullptr), received_handler_(nullptr),
+      is_owned_(true), seq_id_(0) {
 }
 
 VineDp::~VineDp() {

diff --git a/cion/vine/vine_dp.hh b/cion/vine/vine_dp.hh
index a464e83258a919cfbe22750b005aaa0a180c3e3b..5f6605197bca5a63bb3fc496176c812c8ecde699 100644 (file)
--- a/cion/vine/vine_dp.hh
+++ b/cion/vine/vine_dp.hh
@@ -62,9 +62,9 @@ class VineDp {
   std::shared_ptr<VineSession> session_;
 
  private:
-  IVineDpTerminatedEventHandler* terminated_handler_ = nullptr;
-  IVineDpOpenedEventHandler* opened_handler_ = nullptr;
-  IVineDpReceivedEventHandler* received_handler_ = nullptr;
+  IVineDpTerminatedEventHandler* terminated_handler_;
+  IVineDpOpenedEventHandler* opened_handler_;
+  IVineDpReceivedEventHandler* received_handler_;
   bool is_owned_;
 
   unsigned int seq_id_;

diff --git a/cion/vine/vine_session.cc b/cion/vine/vine_session.cc
index 5d731eea563e957aef398b7a11ce121ad945bff8..1d1a0adc8292ed8dcee4cd8835c3ea9cda154106 100644 (file)
--- a/cion/vine/vine_session.cc
+++ b/cion/vine/vine_session.cc
@@ -26,7 +26,7 @@
 
 namespace cion {
 
-VineSession::VineSession() {
+VineSession::VineSession() : loop_(nullptr), jobs_(nullptr) {
   int ret = vine_initialize();
   if (ret != VINE_ERROR_NONE) {
     LOG(ERROR) << "Failed to initialize vine: " << VineErrorToString(ret);