staging: rtl8192u: remove the if condition without effect
authorSaurav Girepunje <saurav.girepunje@gmail.com>
Mon, 8 Nov 2021 04:11:22 +0000 (09:41 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Nov 2021 09:02:04 +0000 (10:02 +0100)
In function rtl8192_adapter_start priv->pFirmware->firmware_status
is assign to FW_STATUS_0_INIT just after assignment variable is
again get check for same value. Therefore if condition will be
always be true. So remove the if condition ,else if section and
else section which will never get execute.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
Link: https://lore.kernel.org/r/YYijapuGOmObwM3S@Sauravs-MacBook-Air.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r8192U_core.c

index 726d7ad..f5d9e81 100644 (file)
@@ -2666,14 +2666,7 @@ static bool rtl8192_adapter_start(struct net_device *dev)
        /* config CPUReset Register */
        /* Firmware Reset or not? */
        read_nic_dword(dev, CPU_GEN, &dwRegRead);
-       if (priv->pFirmware->firmware_status == FW_STATUS_0_INIT)
-               dwRegRead |= CPU_GEN_SYSTEM_RESET; /* do nothing here? */
-       else if (priv->pFirmware->firmware_status == FW_STATUS_5_READY)
-               dwRegRead |= CPU_GEN_FIRMWARE_RESET;
-       else
-               RT_TRACE(COMP_ERR,
-                        "ERROR in %s(): undefined firmware state(%d)\n",
-                        __func__,   priv->pFirmware->firmware_status);
+       dwRegRead |= CPU_GEN_SYSTEM_RESET; /* do nothing here? */
 
        write_nic_dword(dev, CPU_GEN, dwRegRead);
        /* config BB. */