std::vector<InlayHint> Results;
InlayHintVisitor Visitor(Results, AST);
Visitor.TraverseAST(AST.getASTContext());
+
+ // De-duplicate hints. Duplicates can sometimes occur due to e.g. explicit
+ // template instantiations.
+ llvm::sort(Results);
+ Results.erase(std::unique(Results.begin(), Results.end()), Results.end());
+
return Results;
}
return llvm::json::Object{
{"range", H.range}, {"kind", H.kind}, {"label", H.label}};
}
+bool operator==(const InlayHint &A, const InlayHint &B) {
+ return std::tie(A.kind, A.range, A.label) ==
+ std::tie(B.kind, B.range, B.label);
+}
+bool operator<(const InlayHint &A, const InlayHint &B) {
+ return std::tie(A.kind, A.range, A.label) <
+ std::tie(B.kind, B.range, B.label);
+}
static const char *toString(OffsetEncoding OE) {
switch (OE) {
std::string label;
};
llvm::json::Value toJSON(const InlayHint &);
+bool operator==(const InlayHint &, const InlayHint &);
+bool operator<(const InlayHint &, const InlayHint &);
struct ReferenceContext {
/// Include the declaration of the current symbol.
ExpectedHint{": A<float>", "var"});
}
+TEST(TypeHints, Deduplication) {
+ assertTypeHints(R"cpp(
+ template <typename T>
+ void foo() {
+ auto $var[[var]] = 42;
+ }
+ template void foo<int>();
+ template void foo<float>();
+ )cpp",
+ ExpectedHint{": int", "var"});
+}
+
// FIXME: Low-hanging fruit where we could omit a type hint:
// - auto x = TypeName(...);
// - auto x = (TypeName) (...);
} // namespace
} // namespace clangd
-} // namespace clang
\ No newline at end of file
+} // namespace clang