r3d: Add more input value validation
authorMartin Storsjö <martin@martin.st>
Thu, 19 Sep 2013 14:02:36 +0000 (17:02 +0300)
committerMartin Storsjö <martin@martin.st>
Thu, 19 Sep 2013 19:47:26 +0000 (22:47 +0300)
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>
libavformat/r3d.c

index 1da8b88..74a1f2b 100644 (file)
@@ -85,7 +85,7 @@ static int r3d_read_red1(AVFormatContext *s)
 
     framerate.num = avio_rb16(s->pb);
     framerate.den = avio_rb16(s->pb);
-    if (framerate.num && framerate.den) {
+    if (framerate.num > 0 && framerate.den > 0) {
         st->avg_frame_rate = framerate;
     }
 
@@ -281,6 +281,10 @@ static int r3d_read_reda(AVFormatContext *s, AVPacket *pkt, Atom *atom)
     dts = avio_rb32(s->pb);
 
     st->codec->sample_rate = avio_rb32(s->pb);
+    if (st->codec->sample_rate <= 0) {
+        av_log(s, AV_LOG_ERROR, "Bad sample rate\n");
+        return AVERROR_INVALIDDATA;
+    }
 
     samples = avio_rb32(s->pb);