projects
/
platform
/
kernel
/
linux-exynos.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
127af88
)
mcb: request_mem_region() returns NULL on error
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 26 Mar 2015 19:12:49 +0000
(22:12 +0300)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 3 Apr 2015 14:15:30 +0000
(16:15 +0200)
The code here is checking for IS_ERR() when request_mem_region() only
returns NULL on error and never an ERR_PTR.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mcb/mcb-pci.c
patch
|
blob
|
history
diff --git
a/drivers/mcb/mcb-pci.c
b/drivers/mcb/mcb-pci.c
index
0af7361
..
de36237
100644
(file)
--- a/
drivers/mcb/mcb-pci.c
+++ b/
drivers/mcb/mcb-pci.c
@@
-56,9
+56,9
@@
static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
res = request_mem_region(priv->mapbase, CHAM_HEADER_SIZE,
KBUILD_MODNAME);
- if (
IS_ERR(res)
) {
+ if (
!res
) {
dev_err(&pdev->dev, "Failed to request PCI memory\n");
- ret =
PTR_ERR(res)
;
+ ret =
-EBUSY
;
goto out_disable;
}