[EFL] LayoutTestController needs implementation of setDefersLoading

https://bugs.webkit.org/show_bug.cgi?id=82890

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-03
Reviewed by Philippe Normand.

Source/WebKit/efl:

Implement setDefersLoading() in EFL's LayoutTestController so that the
corresponding test case can be removed from the skip list.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setDefersLoading):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement setDefersLoading() in EFL's LayoutTestController so that the
corresponding test case can be removed from the skip list.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads test in EFL now that
its LayoutTestController implements setDefersLoading().

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 78db2d7..f172ea2 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] LayoutTestController needs implementation of setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=82890
+
+        Reviewed by Philippe Normand.
+
+        Unskip loader/navigation-while-deferring-loads test in EFL now that
+        its LayoutTestController implements setDefersLoading().
+
+        * platform/efl/Skipped:
+
 2012-04-03  Alexander Pavlov  <apavlov@chromium.org>
 
         [Chromium] Unreviewed, suppress compositing/reflections/nested-reflection-transformed2.html on Win Debug.

diff --git a/LayoutTests/platform/efl/Skipped b/LayoutTests/platform/efl/Skipped
index 4d279bb..6d425e8 100644 (file)
--- a/LayoutTests/platform/efl/Skipped
+++ b/LayoutTests/platform/efl/Skipped
@@ -587,9 +587,6 @@ storage/domstorage/localstorage/storagetracker
 # EFL's LayoutTestController does not implement setDomainRelaxationForbiddenForURLScheme
 http/tests/security/setDomainRelaxationForbiddenForURLScheme.html
 
-# EFL's LayoutTestController does not implement setDefersLoading
-loader/navigation-while-deferring-loads.html
-
 # EFL's LayoutTestController does not implement overridePreference
 compositing/webgl/webgl-background-color.html
 compositing/webgl/webgl-no-alpha.html

diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
index ece49ce..f437b98 100644 (file)
--- a/Source/WebKit/efl/ChangeLog
+++ b/Source/WebKit/efl/ChangeLog
@@ -1,3 +1,17 @@
+2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] LayoutTestController needs implementation of setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=82890
+
+        Reviewed by Philippe Normand.
+
+        Implement setDefersLoading() in EFL's LayoutTestController so that the
+        corresponding test case can be removed from the skip list.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        (DumpRenderTreeSupportEfl::setDefersLoading):
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
 
         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels

diff --git a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
index 4fd0697..4e76e01 100644 (file)
--- a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
+++ b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
@@ -338,6 +338,16 @@ void DumpRenderTreeSupportEfl::setAutofilled(JSContextRef context, JSValueRef no
     inputElement->setAutofilled(autofilled);
 }
 
+void DumpRenderTreeSupportEfl::setDefersLoading(Evas_Object* ewkView, bool defers)
+{
+    WebCore::Page* page = EWKPrivate::corePage(ewkView);
+
+    if (!page)
+        return;
+
+    page->setDefersLoading(defers);
+}
+
 bool DumpRenderTreeSupportEfl::findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions options)
 {
     WebCore::Page* page = EWKPrivate::corePage(ewkView);

diff --git a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
index c015a6c..fb79bed 100644 (file)
--- a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
+++ b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
@@ -66,6 +66,7 @@ public:
     static void suspendAnimations(Evas_Object* ewkFrame);
     static void setValueForUser(JSContextRef, JSValueRef nodeObject, JSStringRef value);
     static void setAutofilled(JSContextRef, JSValueRef nodeObject, bool autofilled);
+    static void setDefersLoading(Evas_Object* ewkView, bool defers);
 
     static bool findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions);
     static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index d4fb294..20ce9f4 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,5 +1,18 @@
 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
 
+        [EFL] LayoutTestController needs implementation of setDefersLoading
+        https://bugs.webkit.org/show_bug.cgi?id=82890
+
+        Reviewed by Philippe Normand.
+
+        Implement setDefersLoading() in EFL's LayoutTestController so that the
+        corresponding test case can be removed from the skip list.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::setDefersLoading):
+
+2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
+
         [EFL] LayoutTestController needs implementation of goBack
         https://bugs.webkit.org/show_bug.cgi?id=81914
 

diff --git a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
index 088ebd5..53c8a85 100644 (file)
--- a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
+++ b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
@@ -611,10 +611,9 @@ void LayoutTestController::goBack()
     ewk_frame_back(browser->mainFrame());
 }
 
-void LayoutTestController::setDefersLoading(bool)
+void LayoutTestController::setDefersLoading(bool defers)
 {
-    // FIXME: implement to enable loader/navigation-while-deferring-loads.html
-    notImplemented();
+    DumpRenderTreeSupportEfl::setDefersLoading(browser->mainView(), defers);
 }
 
 void LayoutTestController::setAppCacheMaximumSize(unsigned long long size)