Use SmallVectorImpl instead of SmallVector for function parameters (NFC)
authorTian Jin <tjingrant@gmail.com>
Tue, 19 Nov 2019 00:58:32 +0000 (16:58 -0800)
committerA. Unique TensorFlower <gardener@tensorflow.org>
Tue, 19 Nov 2019 00:59:03 +0000 (16:59 -0800)
Closes tensorflow/mlir#247

PiperOrigin-RevId: 281185661

mlir/include/mlir/Dialect/StandardOps/Ops.h
mlir/lib/Dialect/StandardOps/Ops.cpp

index 7798162..64e52ba 100644 (file)
@@ -338,7 +338,7 @@ void printDimAndSymbolList(Operation::operand_iterator begin,
 
 /// Parses dimension and symbol list and returns true if parsing failed.
 ParseResult parseDimAndSymbolList(OpAsmParser &parser,
-                                  SmallVector<Value *, 4> &operands,
+                                  SmallVectorImpl<Value *> &operands,
                                   unsigned &numDims);
 
 llvm::raw_ostream &operator<<(llvm::raw_ostream &os, SubViewOp::Range &range);
index c2195ae..83c0867 100644 (file)
@@ -212,7 +212,7 @@ void mlir::printDimAndSymbolList(Operation::operand_iterator begin,
 // dimension operands parsed.
 // Returns 'false' on success and 'true' on error.
 ParseResult mlir::parseDimAndSymbolList(OpAsmParser &parser,
-                                        SmallVector<Value *, 4> &operands,
+                                        SmallVectorImpl<Value *> &operands,
                                         unsigned &numDims) {
   SmallVector<OpAsmParser::OperandType, 8> opInfos;
   if (parser.parseOperandList(opInfos, OpAsmParser::Delimiter::Paren))