projects / platform / kernel / linux-riscv.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 7891619)
net: ethernet: mtk_eth_soc: correct the max weight of the queue limit for 100Mbps
authorBo-Cun Chen <bc-bocun.chen@mediatek.com>
Wed, 16 Apr 2025 00:51:07 +0000 (01:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:45:44 +0000 (10:45 +0200)
[ Upstream commit 6b02eb372c6776c9abb8bc81cf63f96039c24664 ]

Without this patch, the maximum weight of the queue limit will be
incorrect when linked at 100Mbps due to an apparent typo.

Fixes: f63959c7eec31 ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues")
Signed-off-by: Bo-Cun Chen <bc-bocun.chen@mediatek.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/74111ba0bdb13743313999ed467ce564e8189006.1744764277.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c patch | blob | history

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index bdc424123ee6cf00d510bf837f1f228270e4d8b2..a22a5bdc7ce62821a130e784a0c199f9ef4db681 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -724,7 +724,7 @@ static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
                case SPEED_100:
                        val |= MTK_QTX_SCH_MAX_RATE_EN |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 103) |
-                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 3);
+                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 3) |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
                        break;
                case SPEED_1000:
@@ -747,7 +747,7 @@ static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
                case SPEED_100:
                        val |= MTK_QTX_SCH_MAX_RATE_EN |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 1) |
-                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5);
+                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5) |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
                        break;
                case SPEED_1000:
Domain: System / Kernel