octeontx2-af: Fix uninitialized variable val

In the case where the condition !is_rvu_otx2(rvu) is false variable
val is not initialized and can contain a garbage value. Fix this by
initializing val to zero and bit-wise or'ing in BIT_ULL(51) to val
for the true condition case of !is_rvu_otx2(rvu).

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 4b5a3ab17c6c ("octeontx2-af: Hardware configuration for inline IPsec")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
index ea3e03fa55d45c56d160587be1ba6baa0d319b2e..29b15b544bdc79e9c40e868f935ed8d2d5e32461 100644 (file)
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
@@ -4596,9 +4596,10 @@ static void nix_inline_ipsec_cfg(struct rvu *rvu, struct nix_inline_ipsec_cfg *r
 
        cpt_idx = (blkaddr == BLKADDR_NIX0) ? 0 : 1;
        if (req->enable) {
+               val = 0;
                /* Enable context prefetching */
                if (!is_rvu_otx2(rvu))
-                       val = BIT_ULL(51);
+                       val |= BIT_ULL(51);
 
                /* Set OPCODE and EGRP */
                val |= FIELD_PREP(IPSEC_GEN_CFG_EGRP, req->gen_cfg.egrp);