fix memory leak in tbm_surface_internal_set_debug_data()

 - old_data->value is come from strdup(). so it should be free.

Change-Id: I130ac337bbbd00b7f4fa89886a5c392fc81180b8
Signed-off-by: Minsu Han <minsu81.han@samsung.com>

diff --git a/src/tbm_surface_internal.c b/src/tbm_surface_internal.c
index 2620ff0..6700234 100644 (file)
--- a/src/tbm_surface_internal.c
+++ b/src/tbm_surface_internal.c
@@ -1342,6 +1342,14 @@ tbm_surface_internal_set_debug_data(tbm_surface_h surface, char *key, char *valu
        if (!LIST_IS_EMPTY(&surface->debug_data_list)) {
                LIST_FOR_EACH_ENTRY(old_data, &surface->debug_data_list, item_link) {
                        if (!strcmp(old_data->key, key)) {
+                               if (old_data->value && value && !strncmp(old_data->value, value, strlen(old_data->value))) {
+                                       TBM_TRACE("tbm_surface(%p) Already exist key(%s) and value(%s)!\n", surface, key, value);
+                                       goto add_debug_key_list;
+                               }
+
+                               if (old_data->value)
+                                       free(old_data->value);
+
                                if (value)
                                        old_data->value = strdup(value);
                                else
@@ -1361,6 +1369,7 @@ tbm_surface_internal_set_debug_data(tbm_surface_h surface, char *key, char *valu
 
        LIST_ADD(&debug_data->item_link, &surface->debug_data_list);
 
+add_debug_key_list:
        if (!LIST_IS_EMPTY(&bufmgr->debug_key_list)) {
                LIST_FOR_EACH_ENTRY_SAFE(old_data, tmp, &bufmgr->debug_key_list, item_link) {
                        if (!strcmp(old_data->key, key)) {