net: ethernet: fs-enet: Use generic CRC32 implementation
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 23 Jul 2018 16:20:20 +0000 (18:20 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Jul 2018 20:40:39 +0000 (13:40 -0700)
Use generic kernel CRC32 implementation because it:
1. Should be faster (uses lookup tables),
2. Removes duplicated CRC generation code,
3. Uses well-proven algorithm instead of coding it one more time.

Suggested-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fs_enet/mac-fec.c

index 1fc27c9..99fe2c2 100644 (file)
@@ -18,6 +18,7 @@
 #include <linux/string.h>
 #include <linux/ptrace.h>
 #include <linux/errno.h>
+#include <linux/crc32.h>
 #include <linux/ioport.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
@@ -176,21 +177,10 @@ static void set_multicast_start(struct net_device *dev)
 static void set_multicast_one(struct net_device *dev, const u8 *mac)
 {
        struct fs_enet_private *fep = netdev_priv(dev);
-       int temp, hash_index, i, j;
+       int temp, hash_index;
        u32 crc, csrVal;
-       u8 byte, msb;
-
-       crc = 0xffffffff;
-       for (i = 0; i < 6; i++) {
-               byte = mac[i];
-               for (j = 0; j < 8; j++) {
-                       msb = crc >> 31;
-                       crc <<= 1;
-                       if (msb ^ (byte & 0x1))
-                               crc ^= FEC_CRC_POLY;
-                       byte >>= 1;
-               }
-       }
+
+       crc = ether_crc(6, mac);
 
        temp = (crc & 0x3f) >> 1;
        hash_index = ((temp & 0x01) << 4) |