serial: 8250_omap: fix a timeout loop condition
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 29 Apr 2021 07:19:22 +0000 (10:19 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 14:26:16 +0000 (16:26 +0200)
This loop ends on -1 so the error message will never be printed.

Fixes: 4bcf59a5dea0 ("serial: 8250: 8250_omap: Account for data in flight during DMA teardown")
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YIpd+kOpXKMpEXPf@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index 8ac11ea..c06631c 100644 (file)
@@ -813,7 +813,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
                               poll_count--)
                                cpu_relax();
 
-                       if (!poll_count)
+                       if (poll_count == -1)
                                dev_err(p->port.dev, "teardown incomplete\n");
                }
        }