regulator: s2mps11: Fix GPIO descriptor initialization
authorMarek Szyprowski <m.szyprowski@samsung.com>
Tue, 20 Nov 2018 12:38:44 +0000 (13:38 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 20 Nov 2018 15:25:40 +0000 (15:25 +0000)
GPIO descriptor array must be zero initialized to ensure that core will
properly handle also the case when no external GPIO pin is defined.

Fixes: 1c984942f0a4 ("regulator: s2mps11: Pass descriptor instead of GPIO number")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/s2mps11.c

index 6fec458..63e66f4 100644 (file)
@@ -1134,9 +1134,8 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       s2mps11->ext_control_gpiod = devm_kmalloc_array(&pdev->dev,
-                       rdev_num, sizeof(*s2mps11->ext_control_gpiod),
-                       GFP_KERNEL);
+       s2mps11->ext_control_gpiod = devm_kcalloc(&pdev->dev, rdev_num,
+                              sizeof(*s2mps11->ext_control_gpiod), GFP_KERNEL);
        if (!s2mps11->ext_control_gpiod)
                return -ENOMEM;