cpufreq: qcom-nvmem: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 27 Sep 2022 15:40:20 +0000 (23:40 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 18 Oct 2022 10:52:26 +0000 (16:22 +0530)
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/qcom-cpufreq-nvmem.c

index a154f03..a577586 100644 (file)
@@ -299,11 +299,8 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
        if (drv->data->get_version) {
                speedbin_nvmem = of_nvmem_cell_get(np, NULL);
                if (IS_ERR(speedbin_nvmem)) {
-                       if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
-                               dev_err(cpu_dev,
-                                       "Could not get nvmem cell: %ld\n",
-                                       PTR_ERR(speedbin_nvmem));
-                       ret = PTR_ERR(speedbin_nvmem);
+                       ret = dev_err_probe(cpu_dev, PTR_ERR(speedbin_nvmem),
+                                           "Could not get nvmem cell\n");
                        goto free_drv;
                }