projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
485b4ff
)
clk: imx: pll14xx: Drop wrong shifting
author
Sascha Hauer
<s.hauer@pengutronix.de>
Fri, 4 Mar 2022 12:52:50 +0000
(13:52 +0100)
committer
Abel Vesa
<abel.vesa@nxp.com>
Fri, 4 Mar 2022 15:06:30 +0000
(17:06 +0200)
The code tries to mask the bits in SDIV_MASK from 'tmp'. SDIV_MASK
already contains the shifted value, so shifting it again is wrong.
No functional change though as SDIV_SHIFT is zero.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Link:
https://lore.kernel.org/r/20220304125256.2125023-3-s.hauer@pengutronix.de
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
drivers/clk/imx/clk-pll14xx.c
patch
|
blob
|
history
diff --git
a/drivers/clk/imx/clk-pll14xx.c
b/drivers/clk/imx/clk-pll14xx.c
index
cae64d7
..
b295d8a
100644
(file)
--- a/
drivers/clk/imx/clk-pll14xx.c
+++ b/
drivers/clk/imx/clk-pll14xx.c
@@
-195,7
+195,7
@@
static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
tmp = readl_relaxed(pll->base + DIV_CTL0);
if (!clk_pll14xx_mp_change(rate, tmp)) {
- tmp &= ~
(SDIV_MASK) << SDIV_SHIFT
;
+ tmp &= ~
SDIV_MASK
;
tmp |= rate->sdiv << SDIV_SHIFT;
writel_relaxed(tmp, pll->base + DIV_CTL0);
@@
-261,7
+261,7
@@
static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
tmp = readl_relaxed(pll->base + DIV_CTL0);
if (!clk_pll14xx_mp_change(rate, tmp)) {
- tmp &= ~
(SDIV_MASK) << SDIV_SHIFT
;
+ tmp &= ~
SDIV_MASK
;
tmp |= rate->sdiv << SDIV_SHIFT;
writel_relaxed(tmp, pll->base + DIV_CTL0);