lib: irqchip/plic: fix typo in plic_warm_irqchip_init
authorJan Remes <jan.remes@codasip.com>
Tue, 21 Jun 2022 12:07:39 +0000 (14:07 +0200)
committerAnup Patel <anup@brainfault.org>
Wed, 22 Jun 2022 05:25:27 +0000 (10:55 +0530)
The second invocation of plic_context_init() incorrectly calls the
function with m_cntx_id instead of s_cntx_id. This breaks systems which
only have 1 external interrupt per hart.

Fixes: 8c362e7 ("lib: irqchip/plic: Factor out a context init function")
Signed-off-by: Jan Remes <jan.remes@codasip.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Samuel Holland <samuel@sholland.org>
lib/utils/irqchip/plic.c

index 8c25b9d..73d7788 100644 (file)
@@ -145,7 +145,7 @@ int plic_warm_irqchip_init(const struct plic_data *plic,
 
        /* By default, disable all IRQs for S-mode of target HART */
        if (s_cntx_id > -1) {
-               ret = plic_context_init(plic, m_cntx_id, false, 0x7);
+               ret = plic_context_init(plic, s_cntx_id, false, 0x7);
                if (ret)
                        return ret;
        }