ASoC: pxa: constify snd_pcm_ops structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Mon, 14 Aug 2017 05:56:30 +0000 (11:26 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 14 Aug 2017 16:19:50 +0000 (17:19 +0100)
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/soc.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/pxa/mmp-pcm.c
sound/soc/pxa/pxa2xx-pcm.c

index 38d5999..624d9bd 100644 (file)
@@ -131,7 +131,7 @@ static int mmp_pcm_mmap(struct snd_pcm_substream *substream,
                vma->vm_end - vma->vm_start, vma->vm_page_prot);
 }
 
-static struct snd_pcm_ops mmp_pcm_ops = {
+static const struct snd_pcm_ops mmp_pcm_ops = {
        .open           = mmp_pcm_open,
        .close          = snd_dmaengine_pcm_close_release_chan,
        .ioctl          = snd_pcm_lib_ioctl,
index 636895a..e64958d 100644 (file)
@@ -45,7 +45,7 @@ static int pxa2xx_pcm_hw_free(struct snd_pcm_substream *substream)
        return 0;
 }
 
-static struct snd_pcm_ops pxa2xx_pcm_ops = {
+static const struct snd_pcm_ops pxa2xx_pcm_ops = {
        .open           = __pxa2xx_pcm_open,
        .close          = __pxa2xx_pcm_close,
        .ioctl          = snd_pcm_lib_ioctl,