ASoC: SOF: topology: Fix mem leak in sof_dai_load()

[ Upstream commit 31e721fbd194d5723722eaa21df1d14cee7e12b5 ]

The function has multiple return points at which it is not released
previously allocated memory.

Signed-off-by: Kamil Duljas <kamil.duljas@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20231116213926.2034-2-kamil.duljas@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index a3a3af2..37ec671 100644 (file)
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -1736,8 +1736,10 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index,
        /* perform pcm set op */
        if (ipc_pcm_ops && ipc_pcm_ops->pcm_setup) {
                ret = ipc_pcm_ops->pcm_setup(sdev, spcm);
-               if (ret < 0)
+               if (ret < 0) {
+                       kfree(spcm);
                        return ret;
+               }
        }
 
        dai_drv->dobj.private = spcm;