net: pc300too: move out assignment in if condition

Should not use assignment in if condition.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
index 17d5cb8..7d8eae5 100644 (file)
--- a/drivers/net/wan/pc300too.c
+++ b/drivers/net/wan/pc300too.c
@@ -349,12 +349,14 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
        else
                card->n_ports = 2;
 
-       for (i = 0; i < card->n_ports; i++)
-               if (!(card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]))) {
+       for (i = 0; i < card->n_ports; i++) {
+               card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]);
+               if (!card->ports[i].netdev) {
                        pr_err("unable to allocate memory\n");
                        pc300_pci_remove_one(pdev);
                        return -ENOMEM;
                }
+       }
 
        /* Reset PLX */
        p = &card->plxbase->init_ctrl;